Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install PDB files when available #5665

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

expipiplus1
Copy link
Collaborator

Closes #5562

@expipiplus1 expipiplus1 added the pr: non-breaking PRs without breaking changes label Nov 25, 2024
@expipiplus1 expipiplus1 added this to the Q4 2024 (Fall) milestone Nov 25, 2024
@expipiplus1 expipiplus1 self-assigned this Nov 25, 2024
@expipiplus1 expipiplus1 requested a review from a team as a code owner November 25, 2024 08:15
docs/user-guide/a3-02-reference-capability-atoms.md Outdated Show resolved Hide resolved
@csyonghe
Copy link
Collaborator

csyonghe commented Dec 2, 2024

@cheneym2 @jkwak-work is this good to merge?

@jkwak-work jkwak-work dismissed cheneym2’s stale review December 3, 2024 11:42

The filemode change is reverted

jkwak-work
jkwak-work previously approved these changes Dec 3, 2024
Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@expipiplus1
Copy link
Collaborator Author

/format

@slangbot
Copy link
Contributor

slangbot commented Dec 3, 2024

🌈 Formatted, please merge the changes from this PR

@expipiplus1
Copy link
Collaborator Author

/format

@slangbot
Copy link
Contributor

slangbot commented Dec 3, 2024

🌈 Formatted, please merge the changes from this PR

Copy link
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@expipiplus1 expipiplus1 merged commit 6c655ca into shader-slang:master Dec 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide symbols for end user debugging.
5 participants